Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add paper_trail to initiatives_votes #29

Merged

Conversation

fblupi
Copy link

@fblupi fblupi commented Nov 15, 2022

🎩 What? Why?

Add paper_trail to initiatives_votes.

Testing

Vote for an initiative and check if a new row withitem_type = Decidim::InitiativesVote has been added to the versions table. Try to delete it too and check again the versions table to see another one with destroy event.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

♥️ Thank you!

@fblupi fblupi requested a review from davidbeig November 15, 2022 11:51
Copy link

@davidbeig davidbeig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

I have also removed an initiative and all the votes have a PaperTrail eveeent of destroy.

@fblupi fblupi merged commit 4a3fb9e into release/0.26-stable-bcn Nov 16, 2022
@fblupi fblupi deleted the feat/add-paper-trail-to-initiatives-votes branch November 16, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants