Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show user profile on iniciative #25

Merged

Conversation

fblupi
Copy link

@fblupi fblupi commented Oct 4, 2022

🎩 What? Why?

Shows user profile info on the initiative page.

Testing

Go to an initiative and check a tooltip is shown when you put the mouse over the author

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Screenshot 2022-10-04 at 17 44 11

♥️ Thank you!

@verarojman verarojman self-requested a review October 5, 2022 10:56
Copy link

@verarojman verarojman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fblupi , looks good to me, could you add a simple system test in decidim-initiatives/spec/system/initiative_spec.rb? Thanks!

Copy link

@verarojman verarojman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏾 Perfect, thanks!

@verarojman verarojman merged commit 43c6b7c into release/0.26-stable-bcn Oct 5, 2022
@verarojman verarojman deleted the feat/show-user-profile-on-iniciative branch October 5, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants