Encode non-ASCII characters on external links (decidim#11472) (decidi…

…m#11499)

* Encode non-ASCII characters on external links

* Lint

* Apply suggestions

decidim-core/app/controllers/decidim/links_controller.rb

@@ -35,7 +35,7 @@ def parse_url
     end
 
     def external_url
-      @external_url ||= URI.parse(params[:external_url])
+      @external_url ||= URI.parse(URI::Parser.new.escape(params[:external_url]))
     end
   end
 end

decidim-core/spec/system/external_domain_warning_spec.rb

@@ -28,6 +28,17 @@
     expect(page).to have_link("Another link", href: "http://www.example.org")
   end
 
+  context "when url has special characters" do
+    let(:destination) { "https://example.org/test?foo=bàr" }
+    let(:url) { "http://#{organization.host}/link?external_url=#{destination}" }
+
+    it "does not show invalid url alert" do
+      visit url
+      expect(page).not_to have_content("Invalid URL")
+      expect(page).to have_content("b%C3%A0r")
+    end
+  end
+
   context "when url is invalid" do
     let(:invalid_url) { "http://#{organization.host}/link?external_url=foo" }