Static accountability pages #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaia
force-pushed
the
static-accountability-pages
branch
from
83a3787 to
e5770b9
Compare
josepjaume
approved these changes
May 25, 2017
app/controllers/static_controller.rb
Outdated
| private | ||
|
|
||
| def current_organization | ||
| @current_organization ||= request.env["decidim.current_organization"] |
There was a problem hiding this comment.
You could just include:
include Decidim::NeedsOrganizationAnd this will both ensure you won't access this without an organization and include the current_organization as a helper.
There was a problem hiding this comment.
@josepjaume thanks! I'll use that instead
app/controllers/static_controller.rb
Outdated
| @current_organization ||= request.env["decidim.current_organization"] | ||
| end | ||
|
|
||
| def decidim_page_title |
There was a problem hiding this comment.
Was this left stray? What about I18n?
There was a problem hiding this comment.
@josepjaume oops, I forgot about this one, I'll fix it now
| @@ -0,0 +1,2 @@ | |||
| class Ability < Decidim::Ability | |||
There was a problem hiding this comment.
@josepjaume it breaks in development when I remove this file, but I don't know why
ActionView::Template::Error (uninitialized constant Ability):
1: <li><%= link_to t(".profile"), decidim.account_path %></li>
2: <% if can? :read, :admin_dashboard %>
3: <li><%= link_to t(".admin_dashboard"), decidim_admin.root_path %></li>
4: <% end %>
5: <li><%= link_to t(".sign_out"), decidim.destroy_user_session_path, method: :delete, class: "sign-out-link" %></li>
cancancan (1.16.0) lib/cancan/controller_additions.rb:371:in `current_ability'
cancancan (1.16.0) lib/cancan/controller_additions.rb:394:in `can?'
actionpack (5.0.2) lib/abstract_controller/helpers.rb:68:in `can?'
/Users/amaia/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/bundler/gems/decidim-c400beaf7655/decidim-core/app/views/layouts/decidim/_user_menu.html.erb:2:in `___sers_amaia__rbenv_versions_______lib_ruby_gems_______bundler_gems_decidim_c___beaf_____decidim_core_app_views_layouts_decidim__user_menu_html_erb__3410750993160859078_70276087318260'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
These are the global static accountability pages
📌 Related Issues
📋 Pending tasks