Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mod is preventing Server List Ping from correctly being processed #481

Closed
Joyfulasteroid opened this issue Jul 5, 2024 · 9 comments
Closed
Assignees
Labels
bug Something isn't working confirmed Confirmed bug/approved suggestion critical

Comments

@Joyfulasteroid
Copy link

Modloader

NeoForge

Minecraft Version

1.21

Modloader Version

NeoForge-21.0.51-beta

No Chat Reports Version

NoChatReports-NEOFORGE-1.21-v2.8.0

Modpack Info

https://www.curseforge.com/minecraft/modpacks/all-the-mods-10

The latest.log File

No response

Bug Description

If you have this mod in your mods list it will make it so either the server list does not recieve/process the response from the server at all or if it does it takes a very long amount of time. This includes the MOTD, server icon and the player count. Removing only this mod from ATM10 completely fixes the issue

Screenshot_360

Steps to Reproduce

To reproduce:

  1. Download ATM10
  2. Add a server to the server list

This alos occurs When it is the only mod
To reproduce:

  1. Install NeoForge client
  2. Download NoChatReports NeoForge mod
  3. Add to mods folder
  4. Load game and add server to server list

Other Information

No response

@Gbergz
Copy link

Gbergz commented Jul 6, 2024

Can confirm this issue.

@Joyfulasteroid
Copy link
Author

Hoping this gets fixed soon as it will make some servers avoid using this mod as the MOTD and player counts are what a lot of players look for when joining a new server

@Joyfulasteroid
Copy link
Author

This is still present in the latest versions of Neoforge

@Joyfulasteroid
Copy link
Author

[28Jul2024 21:11:39.551] [Server Pinger #1/DEBUG] [mixin/]: Mixing client.MixinServerStatusPinger$1 from mixins/common/nochatreports.mixins.json into net.minecraft.client.multiplayer.ServerStatusPinger$1
[28Jul2024 21:11:39.552] [Server Pinger #1/DEBUG] [mixin/]: mixins/common/nochatreports.mixins.json:client.MixinServerStatusPinger$1 from mod nochatreports: Class version 65 required is higher than the class version supported by the current version of Mixin (JAVA_18 supports class version 62)
[28Jul2024 21:11:39.552] [Server Pinger #1/DEBUG] [mixin/]: Mixing client.MixinServerStatusPinger$1 from mixins/neoforge/nochatreports-neoforge.mixins.json into net.minecraft.client.multiplayer.ServerStatusPinger$1
[28Jul2024 21:11:39.552] [Server Pinger #1/DEBUG] [mixin/]: mixins/neoforge/nochatreports-neoforge.mixins.json:client.MixinServerStatusPinger$1 from mod nochatreports: Class version 65 required is higher than the class version supported by the current version of Mixin (JAVA_18 supports class version 62)
[28Jul2024 21:11:39.552] [Server Pinger #1/DEBUG] [mixin/]: Renaming synthetic method lambda$static$0(Ljava/lang/Error;)V to md0c4231$nochatreports$lambda$static$0$0 in mixins/neoforge/nochatreports-neoforge.mixins.json:client.MixinServerStatusPinger$1 from mod nochatreports
[28Jul2024 21:11:39.554] [Server Pinger #1/DEBUG] [mixin/]: mixins/common/nochatreports.mixins.json:client.MixinServerStatusPinger$1 from mod nochatreports->@Inject::getNoChatReports(Lnet/minecraft/network/protocol/status/ClientboundStatusResponsePacket;Lorg/spongepowered/asm/mixin/injection/callback/CallbackInfo;)V doesn't use it's CallbackInfo
[28Jul2024 21:11:39.554] [Server Pinger #1/DEBUG] [mixin/]: mixins/common/nochatreports.mixins.json:client.MixinServerStatusPinger$1 from mod nochatreports->@Inject::getNoChatReports(Lnet/minecraft/network/protocol/status/ClientboundStatusResponsePacket;Lorg/spongepowered/asm/mixin/injection/callback/CallbackInfo;)V has 0 override(s) in child classes
[28Jul2024 21:11:39.554] [Server Pinger #1/DEBUG] [mixin/]: mixins/common/nochatreports.mixins.json:client.MixinServerStatusPinger$1 from mod nochatreports->@Inject::getNoChatReports(Lnet/minecraft/network/protocol/status/ClientboundStatusResponsePacket;Lorg/spongepowered/asm/mixin/injection/callback/CallbackInfo;)V won't be passed a CallbackInfo as a result

This is the debug log for it if that helps at all

@Opoodoop
Copy link

i can vouch for this error is:
java.lang.NullPointerException: Cannot invoke "net.minecraft.network.PacketListener.m_7026_(net.minecraft.network.chat.Component)" because the return value of "net.minecraft.network.Connection.m_129538_()" is null

@Joyfulasteroid
Copy link
Author

Issue is still presenting itself on 1.21.1 Neoforge

@P3rf3ctXZer0
Copy link

P3rf3ctXZer0 commented Aug 16, 2024

This is now an issue on modern platforms. I was told back in 1.20.1 this would not be an issue in future versions.

@Joyfulasteroid
Copy link
Author

I have emailed Aizistral and they are aware of it. I was told they would fix it eventually @P3rf3ctXZer0

@KajesLorian
Copy link

This should be fixed on ALL versions this mod is available for. Not everyone updates to newer versions as soon as they're released, and my friends and I are still enjoying mods that don't exist past 1.20.1

This is an important mod, especially to pubic or quazi-public server operators. I want this mod, but I need for me and my friends to stop crashing on the multiplayer select screen more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmed Confirmed bug/approved suggestion critical
Projects
None yet
Development

No branches or pull requests

6 participants