feat: validate index size when transforming #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeqo
force-pushed
the
jeqo/rsm-tx-index-logging
branch
2 times, most recently
from
8287729 to
90e4675
Compare
ivanyu
previously approved these changes
Oct 20, 2023
jeqo
force-pushed
the
jeqo/rsm-tx-index-logging
branch
from
90e4675 to
e721b4a
Compare
AnatolyPopov
approved these changes
Oct 20, 2023
| @@ -465,6 +469,79 @@ void testRequiresCompression(final CompressionType compressionType, final boolea | |||
| assertThat(requires).isEqualTo(expectedResult); | |||
| } | |||
|
|
|||
| @ParameterizedTest | |||
| @ValueSource(booleans = {true, false}) | |||
| void testTransformingIndexes(final boolean encryption) { | |||
There was a problem hiding this comment.
I'd say these tests should not be in this class but somewhere in /test directory since these are plain unit tests.
There was a problem hiding this comment.
The if statements based on parameterized tests arguments is no the best approach and raise a question about overall feasibility of the tests being parameterized but since we had it here earlier let's address it later altogether.
Index size can potentially be zero or too large for transformation to work.
jeqo
force-pushed
the
jeqo/rsm-tx-index-logging
branch
from
e721b4a to
a15f1cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Index size can potentially be zero or too large for transformation to work.