Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GCS demo #405

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Add GCS demo #405

merged 1 commit into from
Oct 3, 2023

Conversation

ivanyu
Copy link
Contributor

@ivanyu ivanyu commented Sep 30, 2023

No description provided.

@ivanyu ivanyu marked this pull request as ready for review September 30, 2023 14:37
@ivanyu ivanyu requested a review from a team as a code owner September 30, 2023 14:37
jeqo
jeqo reviewed Oct 2, 2023
View reviewed changes
Copy link
Contributor

@jeqo jeqo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor doc suggestion

demo/README.md Outdated Show resolved Hide resolved
@jeqo jeqo merged commit c139240 into main Oct 3, 2023
6 checks passed
@jeqo jeqo deleted the ivanyu/demo-gcs branch October 3, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeqo jeqo jeqo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivanyu @jeqo