Make gcs.credentials.default ternary #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanyu
force-pushed
the
ivanyu/gcs-credentials
branch
6 times, most recently
from
23b781b to
a142d05
Compare
AnatolyPopov
requested changes
Sep 19, 2023
There was a problem hiding this comment.
Do we actually need all this machinery for checking if multiple ways to specify credentials were used simultaneously? Looks like a common approach is to specify the priority of credentials lookup and just use the first specified according to that priority, should we follow that?
storage/gcs/src/test/java/io/aiven/kafka/tieredstorage/storage/gcs/GcsStorageConfigTest.java
Outdated
Show resolved
Hide resolved
storage/gcs/src/main/java/io/aiven/kafka/tieredstorage/storage/gcs/CredentialsBuilder.java
Outdated
Show resolved
Hide resolved
ivanyu
force-pushed
the
ivanyu/gcs-credentials
branch
from
a142d05 to
7ddb9ad
Compare
`null` should be the default value for `gcs.credentials.default`, because otherwise certain practical combinations are impossible (e.g. just setting `gcs.credentials.json` without anything else). Also this commit refactors how the credentials settings are validated: the validation logic is completely delegated to `CredentialsBuilder` to have it in one place.
ivanyu
force-pushed
the
ivanyu/gcs-credentials
branch
from
7ddb9ad to
1e828c0
Compare
I like the current approach better, it's intuitive for the user. |
jeqo
approved these changes
Sep 20, 2023
AnatolyPopov
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nullshould be the default value forgcs.credentials.default, because otherwise certain practical combinations are impossible (e.g. just settinggcs.credentials.jsonwithout anything else).Also this commit refactors how the credentials settings are validated: the validation logic is completely delegated to
CredentialsBuilderto have it in one place.