Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GCS e2e tests #374

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Add GCS e2e tests #374

merged 1 commit into from
Oct 3, 2023

Conversation

ivanyu
Copy link
Contributor

@ivanyu ivanyu commented Sep 3, 2023 •
edited
Loading

Closes #373

@ivanyu ivanyu force-pushed the ivanyu/gcs-e2e branch 3 times, most recently from 7318b03 to d755e90 Compare October 3, 2023 09:18
@ivanyu ivanyu marked this pull request as ready for review October 3, 2023 10:05
@ivanyu ivanyu requested a review from a team as a code owner October 3, 2023 10:05
jeqo
jeqo reviewed Oct 3, 2023
View reviewed changes
.github/workflows/main_push_and_pull_request_workflow.yml Outdated
@@ -35,7 +35,7 @@ jobs:
strategy:
matrix:
java-version: [ 11 ]
test: [ 'LocalSystem', 'S3' ]
test: [ 'LocalSystem', 'S3', 'GCS' ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locally failed with GCS "tests not found", maybe safer to use Gcs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is worse...
Look at the "S3" E2E run
image

I'll fix this separately.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here it is: #412

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦🏽

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good now

@ivanyu ivanyu marked this pull request as draft October 3, 2023 11:41
@ivanyu ivanyu marked this pull request as ready for review October 3, 2023 12:23
jeqo
jeqo approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@jeqo jeqo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ivanyu !

@jeqo jeqo merged commit d811672 into main Oct 3, 2023
7 checks passed
@jeqo jeqo deleted the ivanyu/gcs-e2e branch October 3, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeqo jeqo jeqo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add e2e tests for GCS
2 participants
@ivanyu @jeqo