fix(cache:disk): fail when base directory does not exist #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanyu
requested changes
Jul 5, 2023
README.md
Outdated
Comment on lines
113
to
116
| #### Disk-based Chunk Cache | ||
|
|
||
| Requires a base directory (`path` configuration). | ||
| This directory is not created by the plugin, so it needs to be provided before starting the broker. |
There was a problem hiding this comment.
I think we shouldn't put this paragraph in this section, because it's the design overview, not the usage documentation. We can either create the usage section with this paragraph and lots of TBD, or drop it for now until we start writing the documentation.
There was a problem hiding this comment.
Sure, created #312 to follow up, and dropped changes on README.md
jeqo
force-pushed
the
jeqo/fix-cache-disk-base-not-exist
branch
from
0f6739a to
0f44d80
Compare
ivanyu
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, disk-based cache is only validating if directory exist to delete it and re-create child directories.
This approach is inconsistent with how other paths are defined in the plugin, requiring the directory to exist prior to the start of the plugin. The plugin does this to avoid messing with the existing permissions around the preparation of the directory.
Applying the fixes to fail if directory doesn't exist and some additional refactoring.