Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New implementation] Consider adding more metadata to manifest to make remote segments self-sufficient #158

Closed
ivanyu opened this issue Apr 6, 2023 · 0 comments · Fixed by #377
Closed

[New implementation] Consider adding more metadata to manifest to make remote segments self-sufficient #158

ivanyu opened this issue Apr 6, 2023 · 0 comments · Fixed by #377
Assignees
@ivanyu

Comments

@ivanyu
Copy link
Contributor

ivanyu commented Apr 6, 2023 •
edited
Loading

First think if we need this at all. To be able to restore topic from the remote storage in case of disaster is good.

The metadata in RemoteLogSegmentMetadata:

  • RemoteLogSegmentId - encoded in the path;
  • startOffset - encoded in the parth;
  • endOffset;
  • maxTimestampMs;
  • segmentLeaderEpochs;
  • segmentSizeInBytes;
  • RemoteLogSegmentState - should always be COPY_SEGMENT_STARTED when copyLogSegmentData is called.
ivanyu added a commit that referenced this issue Sep 7, 2023
@ivanyu
Store remote log segment metadata
f943941 
To make the segments more self-contained, this commits adds the remote log segment metadata in the manifest. However, it doesn't serialize it back (we don't need it).

Closes #158
@ivanyu ivanyu mentioned this issue Sep 7, 2023
Merged
@ivanyu ivanyu self-assigned this Sep 7, 2023
@bingkunyangvungle bingkunyangvungle mentioned this issue Apr 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivanyu ivanyu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Store remote log segment metadata Aiven-Open/tiered-storage-for-apache-kafka
1 participant
@ivanyu