Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache repomd.xml and use cache when overwrite the repo #24

Merged
merged 1 commit into from
Jul 8, 2022

Conversation

Aiqin-Aiven
Copy link
Contributor

since the sync packages may take a bit time, and repo.xml may have been changed in upstream

@Aiqin-Aiven Aiqin-Aiven force-pushed the aiqin-s3-mirror branch 3 times, most recently from 6ecc9bb to f969567 Compare July 7, 2022 08:08
facetoe
facetoe previously requested changes Jul 7, 2022
Copy link
Collaborator

@facetoe facetoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM just one comment about using TemporaryDirectory to handle the cached repomd.xml.

rpm_s3_mirror/mirror.py Outdated Show resolved Hide resolved
since the sync packages may take a bit time, and repo.xml may have been changed in upstream
@Aiqin-Aiven Aiqin-Aiven dismissed facetoe’s stale review July 8, 2022 01:33

changed to use context manager and keep it open until overwirte repomd.xml

@facetoe facetoe merged commit 48fe87f into master Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants