Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Black code formatter #23

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Use Black code formatter #23

merged 1 commit into from
Apr 13, 2022

Conversation

rominf
Copy link
Contributor

@rominf rominf commented Mar 31, 2022

No description provided.

@rominf rominf force-pushed the rominf-black branch 5 times, most recently from 8b82eb2 to 6e4623a Compare March 31, 2022 08:28
dangquangdon
dangquangdon reviewed Mar 31, 2022
View reviewed changes
Copy link

@dangquangdon dangquangdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes seem to be LGTM. Just a suggestion that maybe the commit can be split into 2, one for black setup and the other is for the reformatted code changes.

@rominf
Copy link
Contributor Author

rominf commented Mar 31, 2022 •
edited
Loading

On the one hand, I understand that 2 commits are easier to read, on the other, first commit then will not pass checks by itself, hence not self-contained. I prefer to leave this as is, especially, since it's less than 100 LOC.

@saaros saaros merged commit 98a53be into master Apr 13, 2022
@rominf rominf deleted the rominf-black branch May 18, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dangquangdon dangquangdon dangquangdon left review comments

@saaros saaros saaros approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rominf @saaros @dangquangdon