Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mypy: pglookout/common.py [BF-1560] #96

Closed

Conversation

Mulugruntz
Copy link
Contributor

No description provided.

@Mulugruntz Mulugruntz self-assigned this Mar 16, 2023
@Mulugruntz Mulugruntz requested a review from a team as a code owner March 16, 2023 14:15
@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.09 🎉

Comparison is base (ca5f52e) 68.00% compared to head (e8702ac) 68.10%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
+ Coverage   68.00%   68.10%   +0.09%     
==========================================
  Files          10       10              
  Lines         972      975       +3     
  Branches      170      170              
==========================================
+ Hits          661      664       +3     
  Misses        253      253              
  Partials       58       58              
Impacted Files Coverage Δ
pglookout/common.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Mulugruntz Mulugruntz changed the title mypy: common.py [BF-1560] mypy: pglookout/common.py [BF-1560] Mar 16, 2023
@Mulugruntz Mulugruntz force-pushed the sgiffard/BF-1560_add_typing/pglookout_common branch 3 times, most recently from de6c71c to e0f2e99 Compare March 17, 2023 08:50
pglookout/common.py Outdated Show resolved Hide resolved
@Mulugruntz Mulugruntz force-pushed the sgiffard/BF-1560_add_typing/pglookout_common branch from e0f2e99 to e92e422 Compare March 20, 2023 11:07
Also in this commit:
- More unit tests;
- Removed redundant `()` in regex.
@Mulugruntz Mulugruntz force-pushed the sgiffard/BF-1560_add_typing/pglookout_common branch from e92e422 to e8702ac Compare March 22, 2023 11:21
@Mulugruntz
Copy link
Contributor Author

This PR and the other ones related to type hinting will be handled in #106.

@Mulugruntz Mulugruntz closed this Mar 24, 2023
@Mulugruntz
Copy link
Contributor Author

This PR and the other ones related to type hinting will be handled in #106.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants