Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix import error version.py for fedora 39 [SRE-7997] #115

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

rushidave
Copy link
Collaborator

Package build failure on fedora 39, seen below:

[2024-01-21T10:54:07.962Z] + python3 setup.py install --root=/srv/jenkins/workspace/aiven-deps-mb-f38-x86_64_main/rpmbuild/BUILDROOT/pglookout-2.0.2-11.fc39.x86_64
[2024-01-21T10:54:07.962Z] Traceback (most recent call last):
[2024-01-21T10:54:07.962Z]   File "/srv/jenkins/workspace/aiven-deps-mb-f38-x86_64_main/rpmbuild/BUILD/pglookout-028ba9e6002c8a50c6c7f8147ab02620e12f12f7/setup.py", line 4, in <module>
[2024-01-21T10:54:07.962Z]     import version
[2024-01-21T10:54:07.962Z]   File "/srv/jenkins/workspace/aiven-deps-mb-f38-x86_64_main/rpmbuild/BUILD/pglookout-028ba9e6002c8a50c6c7f8147ab02620e12f12f7/version.py", line 9, in <module>
[2024-01-21T10:54:07.962Z]     import imp
[2024-01-21T10:54:07.962Z] ModuleNotFoundError: No module named 'imp'

@rushidave rushidave self-assigned this Jan 31, 2024
@rushidave rushidave requested a review from alexole January 31, 2024 18:44
@rushidave rushidave force-pushed the rushidave-deprecated-version-py branch from bc227d4 to 87477b8 Compare January 31, 2024 18:44
@kmichel-aiven
Copy link
Contributor

@alexole Looks good to me (and I double-checked by running it locally) but I don't have merge power on that repo.

@alexole
Copy link
Contributor

alexole commented Feb 2, 2024

@kmichel-aiven apparently I don't have too, will need to fix that and will merge.

@alexole alexole merged commit acb4edf into main Feb 5, 2024
21 checks passed
@alexole alexole deleted the rushidave-deprecated-version-py branch February 5, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants