Update project to meet PEP-0621 #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RommelLayco
force-pushed
the
RommelLayco-build-using-pyproject.toml
branch
3 times, most recently
from
846e209 to
991f333
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #617 +/- ##
==========================================
- Coverage 91.10% 90.88% -0.22%
==========================================
Files 32 31 -1
Lines 4823 4917 +94
==========================================
+ Hits 4394 4469 +75
- Misses 429 448 +19 |
ferventer
reviewed
Mar 18, 2024
| .PHONY: unittest | ||
| unittest: version | ||
| unittest: dev-deps |
There was a problem hiding this comment.
Just to understand it better, the dev-deps instead of version with run this section?
dev-deps:
pip install .
pip install ".[dev]"
There was a problem hiding this comment.
yeap. as i needed the dependencies installed to run things like unittest etc
RommelLayco
force-pushed
the
RommelLayco-build-using-pyproject.toml
branch
from
991f333 to
59767f6
Compare
Currently we use a custom a script to generate a version for this project. Migrate the definition of the project to a pyproject.toml to meet python standards and allow us to use build tool like hatch which will generate the version for the package.
RommelLayco
force-pushed
the
RommelLayco-build-using-pyproject.toml
branch
from
59767f6 to
fa546e1
Compare
facetoe
approved these changes
Mar 26, 2024
| "types-requests", | ||
| "types-six", | ||
| ] | ||
| contraints = [ |
There was a problem hiding this comment.
I am not sure if this is used for anything, but you have a spelling error here, contraints -> constraints
There was a problem hiding this comment.
oh yeah this is used in the github workflow. i will fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
This update the project to use pep-0621.
Resolves: #xxxxx
Why this way