maintenance: Add getAllTeamsSUFromRegisterUser, getAllTeamsSUOnly, ge… #2530
Conversation
…tAllTeamsSU, deleteTeam, updateTeam and changePwd for UserTeamsControllerService Signed-off-by: Khatib Tamal <[email protected]>
…tAllTeamsSU, deleteTeam, updateTeam and changePwd for UserTeamsControllerService Signed-off-by: Khatib Tamal <[email protected]>
muralibasani
force-pushed
the
2427-finalize-unit-tests-for-usersteamscontrollerservice
branch
from
e724260 to
11438e2
Compare
|
@khatibtamal I will take a look today |
|
|
||
| @Test | ||
| public void getAllTeamsSU() {} | ||
| public void getAllTeamsSUFromRegisterUsersEnvInvalidForTenant() { |
There was a problem hiding this comment.
this is good one indeed
|
@khatibtamal thank you for such beautiful tests with high coverage. Looks good to me. |
Yeah I am sorry, between getting sick and then trying to catch up at work, I haven't had a chance to look at this yet, but I am going to check it out this morning. Thanks a million for being so patient! |
Thanks a lot! appreciate |
…rsteamscontrollerservice' into 2427-finalize-unit-tests-for-usersteamscontrollerservice
Thanks @aindriu-aiven hope you are well now. I have updated the branch. |
…steamscontrollerservice
…steamscontrollerservice
…tAllTeamsSU, deleteTeam, updateTeam and changePwd for UserTeamsControllerService
Linked issue
Resolves: #2427
What kind of change does this PR introduce?
What is the current behavior?
UsersTeamsControllerService.java has unit test line coverage of apprx 70%.
What is the new behavior?
New unit tests added for
getAllTeamsSUFromRegisterUsers,getAllTeamsSUOnly,updateTeam,changePwd. The following tests were further refinedgetAllTeamsSU,deleteTeam.Other information
There was a test for
getAllTeamsSUOnlybut it was in fact testinggetAllTeamsSU, the name was changed andgetAllTeamsSUwas refined. InUsersTeamsControllerService.javathere was some unused code, which was removed. Now the line coverage of tests forUsersTeamsControllerServiceis 86%.Requirements (all must be checked before review)
mainbranch have been pulledpnpm linthas been run successfully