maintenance: Add getNewUserRequests, approveNewUserRequests, declineN…

[khatibtamal]

…ewUserRequests and getRegistrationInfoFromId for UserTeamsControllerService

Linked issue

Resolves: #2519

What kind of change does this PR introduce?

• Bug fix
• New feature
• Refactor
• Docs update
• CI update

What is the current behavior?

UsersTeamsControllerService.java lacks unit tests for getNewUserRequests, approveNewUserRequests, declineNewUserRequests and getRegistrationInfoFromId

What is the new behavior?

Unit tests added for getNewUserRequests, approveNewUserRequests, declineNewUserRequests and getRegistrationInfoFromId in UsersTeamsControllerServiceTest

Other information

A null check had to be added in UserTeamsControllerService.java because this test case generates an exception with null message

Requirements (all must be checked before review)

• The pull request title follows our guidelines
• Tests for the changes have been added (if relevant)
• The latest changes from the main branch have been pulled
• pnpm lint has been run successfully

[khatibtamal]

@aindriu-aiven In UserTeamsControllerService.java here there is no tenant wise filtering of the user requests, and the team name that is being pulled is based on the tenant of the authenticated user. Is this intentional?

[khatibtamal]

@aindriu-aiven FYI tenantId and teamName are un used params here I avoided touching them to avoid cascading changes in other files. Please let me know if you want them removed

[aindriu-aiven]

@khatibtamal I've set aside time tomorrow to do this review, sorry for the delay really appreciate it!

[khatibtamal]

@khatibtamal I've set aside time tomorrow to do this review, sorry for the delay really appreciate it!

no problem, please do it at your convenience. thanks!

[aindriu-aiven]

LGTM! Thanks a million for your contribution!

[khatibtamal]

LGTM! Thanks a million for your contribution!

Hello thanks! But I cannot merge it.

[aindriu-aiven]

LGTM! Thanks a million for your contribution!

Hello thanks! But I cannot merge it.

Sorry I was waiting for the build to complete so I could merge it and got distracted, thanks for the reminder!