Fix validation to parse partitions as ints first #2512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aindriu Lavelle <[email protected]>
| @@ -705,6 +705,11 @@ app.controller("envsCtrl", function($scope, $http, $location, $window) { | |||
|
|
|||
| $scope.addNewEnv = function() { | |||
|
|
|||
| var defRepFactor = parseInt($scope.addNewEnv.defrepfctr,10) | |||
| var maxRepFactor = parseInt($scope.addNewEnv.maxrepfctr,10) | |||
| var defPartitionFactor = parseInt($scope.addNewEnv.defparts,10) | |||
There was a problem hiding this comment.
Suggested change
| var defPartitionFactor = parseInt($scope.addNewEnv.defparts,10) | |
| var defPartitions = parseInt($scope.addNewEnv.defparts,10) |
There was a problem hiding this comment.
well that was a silly mistake to make gimme two minutes and I'll fix it
| var defRepFactor = parseInt($scope.addNewEnv.defrepfctr,10) | ||
| var maxRepFactor = parseInt($scope.addNewEnv.maxrepfctr,10) | ||
| var defPartitionFactor = parseInt($scope.addNewEnv.defparts,10) | ||
| var maxPartitionFactor = parseInt($scope.addNewEnv.defmaxparts,10) |
There was a problem hiding this comment.
Suggested change
| var maxPartitionFactor = parseInt($scope.addNewEnv.defmaxparts,10) | |
| var maxPartitions = parseInt($scope.addNewEnv.defmaxparts,10) |
Signed-off-by: Aindriu Lavelle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issue
Resolves: #2508
What kind of change does this PR introduce?
What is the current behavior?
Strings are compared to each other for default and max paritions and replication
What is the new behavior?
Strings are parsed to ints then compared to each other for default and max paritions and replication
Other information
Additional changes, explanations of the approach taken, unresolved issues, necessary follow ups, etc.
Requirements (all must be checked before review)
mainbranch have been pulledpnpm linthas been run successfully