Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When deleting Aiven acls, the associated service user will now be deleted #2374

Merged
merged 8 commits into from
Apr 2, 2024

Conversation

muralibasani
Copy link
Contributor

Linked issue

Resolves: #2371

When deleting Aiven acls, the associated service user will now be deleted, if its not linked to any other topic.

What kind of change does this PR introduce?

  • Bug fix
  • New feature
  • [ X] Refactor
  • Docs update
  • CI update

What is the current behavior?

Describe the state of the application before this PR. Illustrations appreciated (videos, gifs, screenshots).

What is the new behavior?

Describe the state of the application after this PR. Illustrations appreciated (videos, gifs, screenshots).

Other information

Additional changes, explanations of the approach taken, unresolved issues, necessary follow ups, etc.

Requirements (all must be checked before review)

  • The pull request title follows our guidelines
  • Tests for the changes have been added (if relevant)
  • The latest changes from the main branch have been pulled
  • pnpm lint has been run successfully

@muralibasani muralibasani changed the title Rel 290 acl When deleting Aiven acls, the associated service user will now be deleted Mar 28, 2024
Copy link
Contributor

@aindriu-aiven aindriu-aiven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muralibasani muralibasani merged commit 96b2c96 into main Apr 2, 2024
24 checks passed
@muralibasani muralibasani deleted the rel-290-acl branch April 2, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete a service user on ACL delete
2 participants