Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for clusterType param in getClustersPaginated endpoint #2327

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

programmiri
Copy link
Contributor

@programmiri programmiri commented Feb 27, 2024

Linked issue

Resolves to: #2314

What kind of change does this PR introduce?

  • Bug fix
  • New feature
  • Refactor
  • Docs update
  • CI update

What is the current behavior?

While getClustersPaginated has a parameter typeOfCluster, it uses:

List<KwClustersModelResponse> kwClustersModelList = getClusters("all");

What is the new behavior?

To enabed filtering by clusterType in coral later:

  • getClustersPaginated now expects typeOfCluster being oft type KafkaClustersType

getClustersPaginated does take a string (representing the enum of KafkaClustersType typeOfCluster

  • it passes String clusterTypeValue = typeOfCluster.value; to getClusters (this way, there are no further changes needed related to getClusters
  • it changes "all" to "ALL" for the call to getClustersPaginated in env.js in Angular (that's the only place I've found it used)
  • changes "all" to "ALL" in the same call in coral

Other information

Additional changes, explanations of the approach taken, unresolved issues, necessary follow ups, etc.

Requirements (all must be checked before review)

  • The pull request title follows our guidelines
  • Tests for the changes have been added (if relevant)
  • The latest changes from the main branch have been pulled
  • pnpm lint has been run successfully

@programmiri programmiri changed the title 2314 add cluster type filter to paginated feat: Add support for clusterType param in getClustersPaginated endpoint Feb 27, 2024
@programmiri programmiri self-assigned this Feb 27, 2024
@programmiri programmiri added the Backend Backend tasks label Feb 27, 2024
@programmiri programmiri added this to the Klaw Release 2.9.0 milestone Feb 27, 2024
@programmiri programmiri force-pushed the 2314-add-clusterType-filter-to-paginated branch from d5cbd02 to bbe3ad3 Compare February 27, 2024 08:44
@programmiri programmiri marked this pull request as ready for review February 27, 2024 08:44
Copy link
Contributor

@aindriu-aiven aindriu-aiven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@programmiri programmiri merged commit ada600d into main Feb 27, 2024
33 checks passed
@programmiri programmiri deleted the 2314-add-clusterType-filter-to-paginated branch February 27, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend Backend tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(coral): Add support for clusterType param in getClustersPaginated endpoint
2 participants