feat: Add support for clusterType param in getClustersPaginated endpoint #2327
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issue
Resolves to: #2314
What kind of change does this PR introduce?
What is the current behavior?
While
getClustersPaginated
has a parametertypeOfCluster
, it uses:List<KwClustersModelResponse> kwClustersModelList = getClusters("all");
What is the new behavior?
To enabed filtering by
clusterType
in coral later:getClustersPaginated
now expectstypeOfCluster
being oft typeKafkaClustersType
getClustersPaginated
does take a string (representing the enum ofKafkaClustersType
typeOfCluster
String clusterTypeValue = typeOfCluster.value;
togetClusters
(this way, there are no further changes needed related togetClusters
getClustersPaginated
inenv.js
in Angular (that's the only place I've found it used)Other information
Additional changes, explanations of the approach taken, unresolved issues, necessary follow ups, etc.
Requirements (all must be checked before review)
main
branch have been pulledpnpm lint
has been run successfully