Make MailUtils lazy #2204
Merged
Make MailUtils lazy #2204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snuyanzin
force-pushed
the
mail
branch
2 times, most recently
from
1517f38 to
5f467e4
Compare
snuyanzin
commented
Jan 17, 2024
| + m.approverUsername | ||
| + "because : " | ||
| + m.reasonToDecline), | ||
| REGISTER_USER_REQUEST("TODO", (Function<MailInfo, String>) null), |
There was a problem hiding this comment.
No usages of this were found, should we just remove it?
There was a problem hiding this comment.
Yeah you can remove it, its called from another area (that i literally was looking at a few hours ago because of a seperate bug Murali fixed )
There was a problem hiding this comment.
ok, thanks for confirmation, removed
snuyanzin
commented
Jan 17, 2024
| + m.acl | ||
| + " by team : " | ||
| + m.username), | ||
| NEW_USER_ADDED("TODO", (Function<MailInfo, String>) null), |
There was a problem hiding this comment.
No usages of this were found, should we just remove it?
There was a problem hiding this comment.
ok, thanks for confirmation, removed
snuyanzin
force-pushed
the
mail
branch
2 times, most recently
from
94b1455 to
ed9c64e
Compare
aindriu-aiven
approved these changes
Jan 17, 2024
Signed-off-by: Sergey Nuyanzin <[email protected]>
Signed-off-by: Sergey Nuyanzin <[email protected]>
|
Thanks for taking a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main idea is ,ovement knowledge about what property should be loaded for a specific
MailTypetoMailTypeitself. After that it makes it loading a lazy way by loading only what is required