-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cora): Update login page styles to match coral
#2203
Conversation
Signed-off-by: Mathieu Anderson <[email protected]>
Signed-off-by: Mathieu Anderson <[email protected]>
Signed-off-by: Mathieu Anderson <[email protected]>
54b4590
to
f109f7e
Compare
Signed-off-by: Mathieu Anderson <[email protected]>
Signed-off-by: Mathieu Anderson <[email protected]>
@mathieu-anderson works well, I just checked locally all I found (not sure how I get to e.g. loginSaas 🤔 ) I noticed that I can register as a user even if I don't check the terms of service, that's probably something we should change? I also noticed that other than some text inputs (not all), the elements don't have focus style, so it's not very friendly for keyboard users. I'm not sure if we should change that in this PR, because it's already big, but I think we can create a ticket for that for later? It's probably a small change and would be really nice for users. |
Probably, but you will notice that if you click on the terms link, nothing happens. It is definitely quite broken. Screen.Recording.2024-01-17.at.13.41.02.mov
I would say this will be taken care of when we move the auth pages to coral for real. |
coral
coral
^^ Then I would say we remove it if we don't need it or make it required and add something there if we need it? We don't have to do it in this PR, but I think the product looks a bit more professional if we fix it later.
Sure! I may check later the week or so if it's a SUPER small change and throw in a PR, but very timeboxed 😇 |
@programmiri regarding the Terms, it should actually be removed entirely, as the project cannot apply terms to users (the orgs using the project would add their own terms). Will edit the issue to redesign signup |
What kind of change does this PR introduce?
What is the current behavior?
Login page is quite jarring stylistically when used to log into
coral
What is the new behavior?
Screen.Recording.2024-01-17.at.10.18.12.mov
Other information
Other login-related pages should be updated too :
looginSaas
)Requirements (all must be checked before review)
main
branch have been pulledpnpm lint
has been run successfully