Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cora): Update login page styles to match coral #2203

Merged
merged 9 commits into from
Jan 17, 2024
Merged

Conversation

mathieu-anderson
Copy link
Contributor

@mathieu-anderson mathieu-anderson commented Jan 15, 2024

What kind of change does this PR introduce?

  • Bug fix
  • New feature
  • Refactor
  • Docs update
  • CI update

What is the current behavior?

Login page is quite jarring stylistically when used to log into coral

What is the new behavior?

  • delete all SAAS-like data from login page
  • change colors (bg white, main blue the same as the blue used by coral)
  • change font from Poppins to Inter (used by coral)
  • other changes related to provided design
Screen.Recording.2024-01-17.at.10.18.12.mov

Other information

Other login-related pages should be updated too :

Requirements (all must be checked before review)

  • The pull request title follows our guidelines
  • Tests for the changes have been added (if relevant)
  • The latest changes from the main branch have been pulled
  • pnpm lint has been run successfully

Mathieu Anderson added 2 commits January 15, 2024 14:11
@mathieu-anderson mathieu-anderson added enhancement New feature or request Frontend Relates to coral (react app) wip labels Jan 15, 2024
@mathieu-anderson mathieu-anderson self-assigned this Jan 15, 2024
Signed-off-by: Mathieu Anderson <[email protected]>
Signed-off-by: Mathieu Anderson <[email protected]>
@mathieu-anderson mathieu-anderson marked this pull request as ready for review January 17, 2024 09:25
Signed-off-by: Mathieu Anderson <[email protected]>
@programmiri
Copy link
Contributor

@mathieu-anderson works well, I just checked locally all I found (not sure how I get to e.g. loginSaas 🤔 )

I noticed that I can register as a user even if I don't check the terms of service, that's probably something we should change?

I also noticed that other than some text inputs (not all), the elements don't have focus style, so it's not very friendly for keyboard users. I'm not sure if we should change that in this PR, because it's already big, but I think we can create a ticket for that for later? It's probably a small change and would be really nice for users.

@mathieu-anderson
Copy link
Contributor Author

I noticed that I can register as a user even if I don't check the terms of service, that's probably something we should change?

Probably, but you will notice that if you click on the terms link, nothing happens. It is definitely quite broken.

Screen.Recording.2024-01-17.at.13.41.02.mov

I also noticed that other than some text inputs (not all), the elements don't have focus style, so it's not very friendly for keyboard users. I'm not sure if we should change that in this PR, because it's already big, but I think we can create a ticket for that for later? It's probably a small change and would be really nice for users.

I would say this will be taken care of when we move the auth pages to coral for real.

@mathieu-anderson mathieu-anderson changed the title [POC] feat(cora): Update login page styles to match coral feat(cora): Update login page styles to match coral Jan 17, 2024
@programmiri
Copy link
Contributor

Probably, but you will notice that if you click on the terms link, nothing happens. It is definitely quite broken.

^^

Then I would say we remove it if we don't need it or make it required and add something there if we need it? We don't have to do it in this PR, but I think the product looks a bit more professional if we fix it later.

I would say this will be taken care of when we move the auth pages to coral for real.

Sure! I may check later the week or so if it's a SUPER small change and throw in a PR, but very timeboxed 😇

@mathieu-anderson
Copy link
Contributor Author

mathieu-anderson commented Jan 17, 2024

@programmiri regarding the Terms, it should actually be removed entirely, as the project cannot apply terms to users (the orgs using the project would add their own terms).

Will edit the issue to redesign signup

@programmiri programmiri merged commit 185bde0 into main Jan 17, 2024
24 checks passed
@programmiri programmiri deleted the css-update branch January 17, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Frontend Relates to coral (react app)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants