-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(coral): Subscription details: Fix consumer offsets #2017
Merged
+339
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions Signed-off-by: Mathieu Anderson <mathieu.anderson@aiven.io>
Loading status checks…
…ier check on openapi.yaml Signed-off-by: Mathieu Anderson <mathieu.anderson@aiven.io>
mathieu-anderson
added
bug
Something isn't working
enhancement
New feature or request
Backend
Backend tasks
Frontend
Relates to coral (react app)
labels
Nov 23, 2023
mathieu-anderson
requested review from
programmiri,
muralibasani and
aindriu-aiven
November 23, 2023 16:10
programmiri
approved these changes
Nov 24, 2023
@@ -36,9 +36,6 @@ | |||
], | |||
"**/*.{md, css}": [ | |||
"prettier --check" | |||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird, I also thought we've already removed that 🤔
onClick: closeDetailsModal, | ||
onClick: () => { | ||
closeDetailsModal(); | ||
queryClient.removeQueries({ queryKey: ["getConsumerOffsets"] }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL about removeQueries
💡
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Backend
Backend tasks
bug
Something isn't working
enhancement
New feature or request
Frontend
Relates to coral (react app)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issue
Resolves: #1453
What kind of change does this PR introduce?
What is the current behavior?
The consumers offset is a dynamic value which should only be displayed on user request, and should be able to be refetched on user request.
Currently it is fetched once and then cached. It also only shows the offsets for partion 0.
What is the new behavior?
Screen.Recording.2023-11-23.at.17.08.07.mov
Other information
OffsetDetails
model prperties required foropenapi
spec.openapi.yaml
, it's autogenerated. Also, thought I did that before :oRequirements (all must be checked before review)
main
branch have been pulledpnpm lint
has been run successfully