Edit schema reqs #1983
Merged
Edit schema reqs #1983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 13, 2023 10:39
Signed-off-by: muralibasani <[email protected]>
Signed-off-by: muralibasani <[email protected]>
Signed-off-by: muralibasani <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -376,6 +376,15 @@ public String editAclRequest( | |||
| return checkAuth("editAclRequest.html", request, response, abstractAuthenticationToken); | |||
| } | |||
|
|
|||
| @RequestMapping(value = "/editSchemaRequest", method = RequestMethod.GET) | |||
| public String editSchemaRequest( | |||
| ModelMap model, | |||
There was a problem hiding this comment.
is model required here? I don't see it used in this class
There was a problem hiding this comment.
As we added a new html page, we would need this.
aindriu-aiven
requested changes
Nov 13, 2023
There was a problem hiding this comment.
I was testing it and found I got a "Schema Request : Failure. Schema request is not owned by you." when I did own the request.
Also after it failed the first time the topic got wiped from the form and I couldnt retry either.
There is no log message around why this occured either.
Signed-off-by: muralibasani <[email protected]>
Signed-off-by: muralibasani <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issue
Resolves: #1737
What kind of change does this PR introduce?
What is the current behavior?
Describe the state of the application before this PR. Illustrations appreciated (videos, gifs, screenshots).
Currently it is not possible to edit the schema requests created by owners of the requests
What is the new behavior?
Describe the state of the application after this PR. Illustrations appreciated (videos, gifs, screenshots).
Other information
Additional changes, explanations of the approach taken, unresolved issues, necessary follow ups, etc.
Requirements (all must be checked before review)
mainbranch have been pulledpnpm linthas been run successfully