-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update schema request with kafka env #1846
Conversation
Signed-off-by: muralibasani <[email protected]>
@programmiri I think we need FE changes here |
Signed-off-by: Mirjam Aulbach <[email protected]>
Signed-off-by: Mirjam Aulbach <[email protected]>
Signed-off-by: Mirjam Aulbach <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I also tested this locally creating a new schema and had no issue with the environment assignement.
Signed-off-by: Mirjam Aulbach <[email protected]>
bb96540
to
51caeed
Compare
Signed-off-by: Mirjam Aulbach <[email protected]>
Signed-off-by: Mirjam Aulbach <[email protected]>
Signed-off-by: muralibasani <[email protected]>
Signed-off-by: Mirjam Aulbach <[email protected]>
Signed-off-by: Mirjam Aulbach <[email protected]>
Signed-off-by: Mirjam Aulbach <[email protected]>
Signed-off-by: Mirjam Aulbach <[email protected]>
Signed-off-by: Mirjam Aulbach <[email protected]>
Signed-off-by: Mirjam Aulbach <[email protected]>
2c7120f
to
66707b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finished testing it, was unable to fully test the promotion aspect due to issues with my environment but both angular and React crated new requests correctly with the Kafka environment Id
🎉 We still should wait for Mathieu to do a review for the frontend changes. |
Linked issue
Resolves: #1593
What kind of change does this PR introduce?
What is the current behavior?
Describe the state of the application before this PR. Illustrations appreciated (videos, gifs, screenshots).
To submit a schema request, currently schema environment is passed in for environment parameter.
What is the new behavior?
Describe the state of the application after this PR. Illustrations appreciated (videos, gifs, screenshots).
Other information:
Additional changes, explanations of the approach taken, unresolved issues, necessary follow ups, etc.
Please check if the PR fulfills these requirements