Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update schema request with kafka env #1846

Merged
merged 19 commits into from
Oct 13, 2023
Merged

Update schema request with kafka env #1846

merged 19 commits into from
Oct 13, 2023

Conversation

muralibasani
Copy link
Contributor

@muralibasani muralibasani commented Oct 5, 2023

Linked issue

Resolves: #1593

What kind of change does this PR introduce?

  • Bug fix
  • New feature
  • Refactor
  • Docs update
  • CI update

What is the current behavior?

Describe the state of the application before this PR. Illustrations appreciated (videos, gifs, screenshots).
To submit a schema request, currently schema environment is passed in for environment parameter.

What is the new behavior?

Describe the state of the application after this PR. Illustrations appreciated (videos, gifs, screenshots).

  • To submit a schema request, kafka environment is passed in for environment parameter. This allows us to remove unnecessary call to get schema environments list api, and keeps it unique to promotion of schema too
  • Deletes an api getEnvsForSchemaRequests
  • In Angular : removed topic and env selection in schema request form

Other information:

Additional changes, explanations of the approach taken, unresolved issues, necessary follow ups, etc.

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)

@muralibasani
Copy link
Contributor Author

@programmiri I think we need FE changes here

aindriu-aiven
aindriu-aiven previously approved these changes Oct 5, 2023
Copy link
Contributor

@aindriu-aiven aindriu-aiven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I also tested this locally creating a new schema and had no issue with the environment assignement.

Copy link
Contributor

@aindriu-aiven aindriu-aiven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished testing it, was unable to fully test the promotion aspect due to issues with my environment but both angular and React crated new requests correctly with the Kafka environment Id

@programmiri
Copy link
Contributor

🎉 We still should wait for Mathieu to do a review for the frontend changes.

@muralibasani muralibasani merged commit ba75970 into main Oct 13, 2023
21 checks passed
@muralibasani muralibasani deleted the issue1593 branch October 13, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: Update endpoint for request schema form
3 participants