Issue 1711 api pagination updates #1728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aindriu Lavelle <[email protected]>
…-pagination-updates
Signed-off-by: Aindriu Lavelle <[email protected]>
Signed-off-by: Aindriu Lavelle <[email protected]>
Signed-off-by: Aindriu Lavelle <[email protected]>
muralibasani
reviewed
Sep 4, 2023
core/src/main/java/io/aiven/klaw/controller/EnvsClustersTenantsController.java
Outdated
Show resolved
Hide resolved
muralibasani
reviewed
Sep 4, 2023
core/src/main/java/io/aiven/klaw/controller/EnvsClustersTenantsController.java
Outdated
Show resolved
Hide resolved
muralibasani
reviewed
Sep 4, 2023
| .toLowerCase() | ||
| .contains(searchEnvParam.toLowerCase())) | ||
| env -> { | ||
| if (env.getName().toLowerCase().contains(searchEnvParam.toLowerCase()) |
There was a problem hiding this comment.
could there be a bug even before, if we use 'contains' here instead of equals ?
There was a problem hiding this comment.
as this is partial match I think that contains makes more sense, equals would work if we were providing a drop down list but this is like type in "DE" and get everything that has DE in it.
So i think it is ok
Signed-off-by: Aindriu Lavelle <[email protected]>
This was referenced Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
This change adds multiple new end points for the coral UI to interact with and reduces code complexity by re-using a single piece of code to give a paginated resource to schema and connector environments as well.
It also reduces the number of loops of the list of environments and fixes a bug in the pagination.
Resolves: #1711
Why this way