Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coral: setup react query #170

Merged
merged 5 commits into from
Nov 2, 2022
Merged

coral: setup react query #170

merged 5 commits into from
Nov 2, 2022

Conversation

programmiri
Copy link
Contributor

About this change - What it does

  • introduces react query
  • adds a basic usage if useQuery in HomePage to prove that all needed setup is in place
  • adds tests for HomePage to proof all needed setup to tests components using react-query is in place

Resolves: #143

Why this way

I used the HomePage component instead of Login to avoid conflicts with the open PR for the login form.

@programmiri programmiri marked this pull request as ready for review November 1, 2022 15:19
@programmiri programmiri requested review from a team as code owners November 1, 2022 15:19
@programmiri programmiri self-assigned this Nov 1, 2022
@SmuliS SmuliS changed the title 143 setup react query coral: setup react query Nov 2, 2022
Copy link
Contributor

@SmuliS SmuliS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice setup! Couple of nitpicks so that we could align on some test practises. Lets discuss if you agree on those. Happy to also merge this as is but I use this as a opportunity to have discussion on the topic.

coral/src/app/pages/index.test.tsx Outdated Show resolved Hide resolved
coral/src/app/pages/index.test.tsx Outdated Show resolved Hide resolved
- the example confirms that react-query is working.
- it enables to write a test to confirm that all
basic functionality can be tested with the current setup.
@programmiri programmiri force-pushed the 143-setup-react-query branch from 7b86196 to be7b7a3 Compare November 2, 2022 10:22
@programmiri programmiri requested a review from SmuliS November 2, 2022 11:01
Copy link
Contributor

@SmuliS SmuliS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of more things to address, but otherwise LGTM!

coral/src/app/main.tsx Outdated Show resolved Hide resolved
coral/src/app/main.tsx Outdated Show resolved Hide resolved
- use proper dev env instead of hard coded setting
- wrap the right component in condition
@programmiri programmiri force-pushed the 143-setup-react-query branch from 66e0429 to fb3bdda Compare November 2, 2022 14:09
@SmuliS SmuliS merged commit 8525d90 into main Nov 2, 2022
@SmuliS SmuliS deleted the 143-setup-react-query branch November 2, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🪸 Setup react-query
2 participants