-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coral: setup react query #170
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice setup! Couple of nitpicks so that we could align on some test practises. Lets discuss if you agree on those. Happy to also merge this as is but I use this as a opportunity to have discussion on the topic.
- the example confirms that react-query is working. - it enables to write a test to confirm that all basic functionality can be tested with the current setup.
7b86196
to
be7b7a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of more things to address, but otherwise LGTM!
- use proper dev env instead of hard coded setting - wrap the right component in condition
66e0429
to
fb3bdda
Compare
About this change - What it does
useQuery
inHomePage
to prove that all needed setup is in placeHomePage
to proof all needed setup to tests components using react-query is in placeResolves: #143
Why this way
I used the
HomePage
component instead ofLogin
to avoid conflicts with the open PR for the login form.