using RequestOperationType.PROMOTE for promoteSchema

[Sadaf-A]

About this change - using PROMOTE REQUEST_OPERATION_TYPE for promoteSchemas instead of CREATE

Resolves: #1546

[aindriu-aiven]

Hey @Sadaf-A this looks great and works exactly as expected, I noticed one issue which I hadn't included in the original ticket but popped up when I was giving it a quick test.

Under mySchemaRequests and under execSchemas (see links to code below) the PROMOTE enum hadn't been used before so the Request Type is missing from the card.

This can be changed by altering the html

<div ng-show="schemaRequest.requestOperationType == 'CREATE'" class="p-2 border-right" style="width:12%">
											<h6 class="text-primary">Request Type</h6><b>
											<span class="badge badge-info">{{ schemaRequest.requestOperationType }} Schema</span></b>
										</div>
										<div ng-show="schemaRequest.requestOperationType == 'UPDATE'" class="p-2 border-right" style="width:12%">
											<h6 class="text-primary">Request Type</h6><b>
											<span class="badge badge-primary">{{ schemaRequest.requestOperationType }} Schema</span></b>
										</div>
										<div ng-show="schemaRequest.requestOperationType == 'DELETE'" class="p-2 border-right" style="width:12%">
											<h6 class="text-primary">Request Type</h6><b>
											<span class="badge badge-danger">{{ schemaRequest.requestOperationType }} Schema</span></b>
										</div>

to

<div ng-show="schemaRequest.requestOperationType !== 'APPROVED'" class="p-2 border-right" style="width:12%">
											<h6 class="text-primary">Request Type</h6><b>
											<span class="badge badge-info">{{ schemaRequest.requestOperationType }} Schema</span></b>
										</div>

klaw/core/src/main/resources/templates/mySchemaRequests.html

Line 536 in d4e1976

<div ng-show="schemaRequest.requestOperationType == 'CREATE'" class="p-2 border-right" style="width:12%">

klaw/core/src/main/resources/templates/execSchemas.html

Line 558 in d4e1976

<div ng-show="schemaRequest.requestOperationType == 'CREATE'" class="p-2 border-right" style="width:12%">

If you aren't comfortable working with the html updates though I am happy to make them.

Change looks great though thanks so much for contributing!
Thanks,
Aindriú

[aindriu-aiven]

Just added one additional request in another comment

[Sadaf-A]

@aindriu-aiven Thanks I'm glad to know that I was of help. I've also made the changes to the html files as requested by you.

[aindriu-aiven]

@Sadaf-A Great thanks a million I will give this another test and review today!

[aindriu-aiven]

Looks Good To Me.

Tested schema promotion and the correct RequestOperationType is now being used to describe the operation, the schema is being correctly provisioned to the cluster and all of the ids and versions are correctly appearing in the schema view.

Also worth noting that the request type is displaying correctly on the approval and the and myschemaRequests page.