Update query with created state #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: muralibasani <[email protected]>
Signed-off-by: muralibasani <[email protected]>
| @@ -29,7 +29,7 @@ List<Object[]> findAllRecordsCountForTeamId( | |||
|
|
|||
| @Query( | |||
| value = | |||
| "select count(*) from kwaclrequests where (requestor = :userId or approver = :userId) and tenantid = :tenantId", | |||
| "select count(*) from kwaclrequests where (requestor = :userId or approver = :userId) and tenantid = :tenantId and topicstatus='created'", | |||
There was a problem hiding this comment.
Do we need to worry about them being an approver? Maybe if they were the only approver but Im not sure we do need to worry about that?
There was a problem hiding this comment.
i think we should ignore them too, so its their responsibility to setup approvers
Signed-off-by: muralibasani <[email protected]>
aindriu-aiven
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
When a user is deleted, look for existing requests with only created state
Resolves: #1219
Why this way
Helps in removing stale data like inactive users