Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(coral): Remove superfluous defaultValue in TopicSchemaRequest #1144

Merged
merged 1 commit into from
May 11, 2023

Conversation

mathieu-anderson
Copy link
Contributor

About this change - What it does

Navigating to /topic/aivtopic1/request-schema will return this warning in the browser's console:

Warning: Select elements must be either controlled or uncontrolled (specify either the value prop, or the defaultValue prop, but not both). Decide between using a controlled or uncontrolled select element and remove one of these props. More info: https://reactjs.org/link/controlled-components

This is because we set a defaultValue for the Topic name's NativeSelect, when none is needed: its value is already set by the useForm's defaultValues option.

We can therefore safely delete it and solve the conflict.

@mathieu-anderson mathieu-anderson added bug Something isn't working Frontend Relates to coral (react app) labels May 10, 2023
@mathieu-anderson mathieu-anderson requested a review from a team as a code owner May 10, 2023 14:18
@mathieu-anderson mathieu-anderson self-assigned this May 10, 2023
@roope-kar roope-kar merged commit 578a257 into main May 11, 2023
@roope-kar roope-kar deleted the fix-warning-schema-req branch May 11, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Frontend Relates to coral (react app)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants