Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scaffold react app #107

Merged
merged 6 commits into from
Oct 19, 2022
Merged

Scaffold react app #107

merged 6 commits into from
Oct 19, 2022

Conversation

programmiri
Copy link
Contributor

@programmiri programmiri commented Oct 18, 2022 •
edited
Loading

About this change - What it does

  • /coral includes a vite scaffold react app
  • all example pages / assets are removed
  • scripts are working
  • use of yarn or npm instead of pnpm is prevented
  • sets a strict(ish) node version to prevent introduction of incompatible dependencies

Resolves: #102

@programmiri programmiri requested a review from SmuliS October 18, 2022 14:50
@programmiri programmiri self-assigned this Oct 18, 2022
SmuliS
SmuliS requested changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@SmuliS SmuliS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this PR the project is set up in /src/coral/** and I think it mixes up with the API code. I would suggest that we setup coral directly to the repository root. Later, we can consider moving all Java related stuff into its own directory as well.

src/coral/.npmrc Outdated
@@ -0,0 +1,2 @@
node-version>=16.0.0<=16.18.0
engine-strict=true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing newline in the end

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, again 🙈 Sorry I didn't catch that. Linting setup should come next I guess 😅

@programmiri
Copy link
Contributor Author

programmiri commented Oct 19, 2022 •
edited
Loading

(...) is set up in /src/coral/** and I think it mixes up with the API code. I would suggest that we setup coral directly to the repository root.

💡 that sounds good. Should I make a new PR for that one? It seems out of scope for this issue 🤔

Later, we can consider moving all Java related stuff into its own directory as well.
Yes!

@SmuliS
Copy link
Contributor

SmuliS commented Oct 19, 2022

Definitely out of the scope 👍

@SmuliS
Copy link
Contributor

SmuliS commented Oct 19, 2022

Sorry, was a bit too quick typing. I would do the mv src/coral coral in this PR, but not yet touch the Java project.

@programmiri programmiri linked an issue Oct 19, 2022 that may be closed by this pull request
🪸 ui-rewrite: Create scaffold react-app #102
Closed
@SmuliS SmuliS merged commit 5dc8df5 into coral Oct 19, 2022
@SmuliS SmuliS deleted the scaffold-react-app branch October 19, 2022 09:57
@programmiri programmiri linked an issue Oct 20, 2022 that may be closed by this pull request
🪸 ui-rewrite: Setup linting / code formatting #110
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SmuliS SmuliS SmuliS approved these changes

Assignees

@programmiri programmiri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🪸 ui-rewrite: Setup linting / code formatting 🪸 ui-rewrite: Create scaffold react-app
2 participants
@programmiri @SmuliS