Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪸 ui-rewrite: Add github action for static checks #108

Closed
programmiri opened this issue Oct 19, 2022 · 0 comments · Fixed by #127
Closed

🪸 ui-rewrite: Add github action for static checks #108

programmiri opened this issue Oct 19, 2022 · 0 comments · Fixed by #127
Assignees
@SmuliS
Labels
triaged Acknowledged

Comments

@programmiri
Copy link
Contributor

programmiri commented Oct 19, 2022 •
edited
Loading

Goal for this ticket

  • if there are changes in /coral we're running on every PR push:
    • github actions running typechecking, linting and code formatting ("static")

⛔️ Issue is blocked by: #110
@programmiri programmiri changed the title 🪸 ui-rewrite: Add first github actions 🪸 ui-rewrite: Add github action for static checks Oct 19, 2022
@SmuliS SmuliS self-assigned this Oct 19, 2022
SmuliS added a commit that referenced this issue Oct 20, 2022
@SmuliS
feat[coral]: Introduce GH action for Coral PR check
b484344 
Run static chekcs (eslint + prettier) and unitests for every
PR that includes changes to ´/coral/**´

Resolves: #108, #109
SmuliS added a commit that referenced this issue Oct 20, 2022
@SmuliS
feat[coral]: Introduce GH action for Coral PR check
8323a24 
Run static checks (eslint + prettier) and unitests for every
PR that includes changes to ´/coral/**´

Resolves: #108, #109
@SmuliS SmuliS mentioned this issue Oct 20, 2022
Merged
SmuliS added a commit that referenced this issue Oct 21, 2022
@SmuliS
feat[coral]: Introduce GH action for Coral PR check
d7f942b 
Run static checks (eslint + prettier) and unitests for every
PR that includes changes to ´/coral/**´

Resolves: #108, #109
@programmiri programmiri linked a pull request Oct 24, 2022 that will close this issue
feat[coral]: Introduce GH action for Coral PR check #127
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SmuliS SmuliS

Labels
triaged Acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat[coral]: Introduce GH action for Coral PR check Aiven-Open/klaw
2 participants
@programmiri @SmuliS