Merge branch 'offset-message' of github.com:Aiven-Open/klaw into offs…

…et-message
Aiven-Open · Nov 22, 2023 · ad9bd1f · ad9bd1f
2 parents 5dbacfc + bad3928
commit ad9bd1f
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 17 deletions.
diff --git a/coral/src/app/features/topics/details/messages/TopicMessages.test.tsx b/coral/src/app/features/topics/details/messages/TopicMessages.test.tsx
@@ -52,7 +52,7 @@ describe("TopicMessages", () => {
     const switchInput = screen.getByRole("checkbox");
 
     const switchGroupDefault = screen.getByRole("group", {
-      name: "Fetching mode Get the latest messages",
+      name: "Fetching mode Select message offset",
     });
 
     expect(switchGroupDefault).toBeVisible();
@@ -61,7 +61,7 @@ describe("TopicMessages", () => {
     await userEvent.click(switchInput);
 
     const switchGroupCustom = screen.getByRole("group", {
-      name: "Fetching mode Get a specific offset",
+      name: "Fetching mode Specify message offset",
     });
 
     expect(switchGroupCustom).toBeVisible();
@@ -88,7 +88,7 @@ describe("TopicMessages", () => {
     const switchInput = screen.getByRole("checkbox");
 
     const switchGroupDefault = screen.getByRole("group", {
-      name: "Fetching mode Get the latest messages",
+      name: "Fetching mode Select message offset",
     });
 
     expect(switchGroupDefault).toBeVisible();
@@ -115,7 +115,7 @@ describe("TopicMessages", () => {
     const switchInput = screen.getByRole("checkbox");
 
     const switchGroupCustom = screen.getByRole("group", {
-      name: "Fetching mode Get a specific offset",
+      name: "Fetching mode Specify message offset",
     });
 
     expect(switchGroupCustom).toBeVisible();

diff --git a/coral/src/app/features/topics/details/messages/TopicMessages.tsx b/coral/src/app/features/topics/details/messages/TopicMessages.tsx
@@ -150,8 +150,8 @@ function TopicMessages() {
                 labelText="Fetching mode"
                 description={
                   fetchingMode === "Default"
-                    ? "Get the latest messages"
-                    : "Get a specific offset"
+                    ? "Select message offset"
+                    : "Specify message offset"
                 }
               >
                 <Switch

diff --git a/coral/src/app/features/topics/details/messages/components/TopicMessageFilters.test.tsx b/coral/src/app/features/topics/details/messages/components/TopicMessageFilters.test.tsx
@@ -68,7 +68,7 @@ describe("TopicMessageFilters", () => {
       );
       within(
         screen.getByRole("group", {
-          name: "Number of messages Choose how many recent messages you want to view from this topic.",
+          name: "Number of messages Select number of messages to display from this topic",
         })
       )
         .getAllByRole("radio")
@@ -97,12 +97,12 @@ describe("TopicMessageFilters", () => {
       );
       expect(
         screen.getByRole("spinbutton", {
-          name: "Partition ID * Choose which partition you want to query.",
+          name: "Partition ID * Enter partition ID to retrieve last messages",
         })
       ).toBeVisible();
       expect(
         screen.getByRole("spinbutton", {
-          name: "Number of messages * Choose how many recent messages you want to view from this partition.",
+          name: "Number of messages * Set the number of recent messages to display from this partition",
         })
       ).toBeVisible();
     });
@@ -127,10 +127,10 @@ describe("TopicMessageFilters", () => {
       );
 
       const partitionIdInput = screen.getByRole("spinbutton", {
-        name: "Partition ID * Choose which partition you want to query.",
+        name: "Partition ID * Enter partition ID to retrieve last messages",
       });
       const customOffsetInput = screen.getByRole("spinbutton", {
-        name: "Number of messages * Choose how many recent messages you want to view from this partition.",
+        name: "Number of messages * Set the number of recent messages to display from this partition",
       });
 
       await userEvent.type(partitionIdInput, "1");

diff --git a/coral/src/app/features/topics/details/messages/components/TopicMessageFilters.tsx b/coral/src/app/features/topics/details/messages/components/TopicMessageFilters.tsx
@@ -41,9 +41,7 @@ function TopicMessageFilters({
       labelText="Number of messages"
       disabled={disabled}
       onChange={(value) => onDefaultOffsetChange(value as DefaultOffset)}
-      description={
-        "Choose how many recent messages you want to view from this topic."
-      }
+      description={"Select number of messages to display from this topic"}
     >
       {defaultOffsets.map((defaultOffset) => {
         if (defaultOffset === "custom") {
@@ -61,8 +59,8 @@ function TopicMessageFilters({
       <Input
         value={values.partitionId || undefined}
         labelText="Partition ID"
-        placeholder={"1"}
-        description={"Choose which partition you want to query."}
+        placeholder={"0"}
+        description={"Enter partition ID to retrieve last messages"}
         onChange={(e) => onPartitionIdChange(e.target.value)}
         type="number"
         helperText={filterErrors.partitionIdFilters || undefined}
@@ -74,7 +72,7 @@ function TopicMessageFilters({
         labelText="Number of messages"
         placeholder={"50"}
         description={
-          "Choose how many recent messages you want to view from this partition."
+          "Set the number of recent messages to display from this partition"
         }
         onChange={(e) => onCustomOffsetChange(e.target.value)}
         type="number"