fix(core/coral): Make OffsetDetails properties required, remove prett…

…ier check on openapi.yaml

Signed-off-by: Mathieu Anderson <[email protected]>

cluster-api/src/main/java/io/aiven/klaw/clusterapi/models/consumergroup/OffsetDetails.java

@@ -1,14 +1,15 @@
 package io.aiven.klaw.clusterapi.models.consumergroup;
 
+import jakarta.validation.constraints.NotNull;
 import lombok.Data;
 
 @Data
 public class OffsetDetails {
-  private String topicPartitionId;
+  @NotNull private String topicPartitionId;
 
-  private String currentOffset;
+  @NotNull private String currentOffset;
 
-  private String endOffset;
+  @NotNull private String endOffset;
 
-  private String lag;
+  @NotNull private String lag;
 }

coral/package.json

@@ -36,9 +36,6 @@
     ],
     "**/*.{md, css}": [
       "prettier --check"
-    ],
-    "../openapi.yaml": [
-      "prettier --check"
     ]
   },
   "dependencies": {

coral/src/app/features/topics/details/subscriptions/components/ConsumerOffsetsValues.tsx

@@ -15,10 +15,10 @@ interface ConsumerOffsetsProps {
 }
 
 const parseOffsetsContent = ({
-  topicPartitionId = "Unknown",
-  currentOffset = "Unknown",
-  endOffset = "Unknown",
-  lag = "Unknown",
+  topicPartitionId,
+  currentOffset,
+  endOffset,
+  lag,
 }: ConsumerOffsets) => {
   return `Partition ${topicPartitionId}: Current offset ${currentOffset} | End offset ${endOffset} | Lag ${lag}`;
 };
@@ -88,7 +88,7 @@ const ConsumerOffsetsValues = ({
             offsetsData.map((data, index) => {
               return (
                 <Typography.Default
-                  key={data?.topicPartitionId || index}
+                  key={data.topicPartitionId || index}
                   htmlTag="dd"
                 >
                   {parseOffsetsContent(data)}

coral/types/api.d.ts

@@ -1540,10 +1540,10 @@ export type components = {
       teamMembersCount?: number;
     };
     OffsetDetails: {
-      topicPartitionId?: string;
-      currentOffset?: string;
-      endOffset?: string;
-      lag?: string;
+      topicPartitionId: string;
+      currentOffset: string;
+      endOffset: string;
+      lag: string;
     };
     KafkaConnectorRequestsResponseModel: {
       environment: string;

core/src/main/java/io/aiven/klaw/model/cluster/consumergroup/OffsetDetails.java

@@ -1,14 +1,15 @@
 package io.aiven.klaw.model.cluster.consumergroup;
 
+import jakarta.validation.constraints.NotNull;
 import lombok.Data;
 
 @Data
 public class OffsetDetails {
-  private String topicPartitionId;
+  @NotNull private String topicPartitionId;
 
-  private String currentOffset;
+  @NotNull private String currentOffset;
 
-  private String endOffset;
+  @NotNull private String endOffset;
 
-  private String lag;
+  @NotNull private String lag;
 }

core/src/main/java/io/aiven/klaw/model/response/OffsetDetails.java

@@ -1,14 +1,15 @@
 package io.aiven.klaw.model.response;
 
+import jakarta.validation.constraints.NotNull;
 import lombok.Data;
 
 @Data
 public class OffsetDetails {
-  private String topicPartitionId;
+  @NotNull private String topicPartitionId;
 
-  private String currentOffset;
+  @NotNull private String currentOffset;
 
-  private String endOffset;
+  @NotNull private String endOffset;
 
-  private String lag;
+  @NotNull private String lag;
 }

openapi.yaml

@@ -8777,7 +8777,8 @@
           "lag" : {
             "type" : "string"
           }
-        }
+        },
+        "required" : [ "currentOffset", "endOffset", "lag", "topicPartitionId" ]
       },
       "KafkaConnectorRequestsResponseModel" : {
         "properties" : {