Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove python 3.8 support #972

Merged
merged 4 commits into from
Oct 8, 2024
Merged

Remove python 3.8 support #972

merged 4 commits into from
Oct 8, 2024

Conversation

jjaakola-aiven
Copy link
Contributor

About this change - What it does

Remove support for Python 3.8, it is EOL.

@jjaakola-aiven jjaakola-aiven requested review from a team as code owners October 8, 2024 10:36
@jjaakola-aiven jjaakola-aiven changed the title Jjaakola aiven remove python 3.8 Remove python 3.8 support Oct 8, 2024
@jjaakola-aiven jjaakola-aiven force-pushed the jjaakola-aiven-remove-python-3.8 branch from 8e9b478 to 90230ca Compare October 8, 2024 10:40
keejon
keejon previously approved these changes Oct 8, 2024
Copy link
Contributor

@keejon keejon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@keejon keejon enabled auto-merge October 8, 2024 10:43
Copy link

github-actions bot commented Oct 8, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  src/karapace
  schema_models.py
  schema_references.py
  typing.py
  src/karapace/anonymize_schemas
  anonymize_avro.py
  src/karapace/avro_dataclasses
  introspect.py
  models.py
  src/karapace/backup/backends
  reader.py
  v1.py
  v2.py
  writer.py
  src/karapace/backup/backends/v3
  backend.py
  readers.py
  schema.py
  schema_tool.py 9-13, 23
  src/karapace/compatibility/jsonschema
  utils.py
  src/karapace/kafka_rest_apis
  consumer_manager.py
  schema_cache.py
  src/karapace/protobuf
  compare_result.py
  compare_type_storage.py
  io.py
  known_dependency.py
  proto_file_element.py
  proto_parser.py
  utils.py
  src/karapace/protobuf/protopace
  protopace.py
Project Total  

The report is truncated to 25 files out of 61. To see the full report, please visit the workflow summary page.

This report was generated by python-coverage-comment-action

@aiven-anton
Copy link
Contributor

aiven-anton commented Oct 8, 2024

pyupgrade can also be bumped after this:

args: [ --py38-plus ]

(Although, it would be nice to swap all of the tooling to ruff instead)

@jjaakola-aiven
Copy link
Contributor Author

@aiven-anton I'll change to py39, no reason the leave these pending another PR.

Copy link
Contributor

@keejon keejon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jlprat jlprat merged commit 18b46fd into main Oct 8, 2024
9 checks passed
@jlprat jlprat deleted the jjaakola-aiven-remove-python-3.8 branch October 8, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants