Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests, protobuf: add test on invalid reference schema #959

Conversation

davide-armand
Copy link
Contributor

@davide-armand davide-armand commented Sep 23, 2024

Given a valid schema, if it references an invalid (corrupted) schema then:

  • Exception CorruptKafkaRecordException should be raised
  • Warning Invalid Protobuf references should be logged

@davide-armand davide-armand force-pushed the davide-armand/EC-459-protobuf-references-error-handling-tests branch 4 times, most recently from bfe6a79 to ac90c31 Compare September 24, 2024 09:51
@davide-armand davide-armand marked this pull request as ready for review September 24, 2024 09:51
@davide-armand davide-armand requested review from a team as code owners September 24, 2024 09:51
@davide-armand davide-armand force-pushed the davide-armand/EC-459-protobuf-references-error-handling-tests branch 2 times, most recently from dba48f8 to aa2380d Compare September 24, 2024 14:00
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  karapace
  in_memory_database.py
  schema_reader.py
Project Total  

This report was generated by python-coverage-comment-action

@davide-armand davide-armand force-pushed the davide-armand/EC-459-protobuf-references-error-handling-tests branch from aa2380d to 0d9ad85 Compare September 25, 2024 07:21
@davide-armand davide-armand deleted the davide-armand/EC-459-protobuf-references-error-handling-tests branch September 25, 2024 08:39
@davide-armand
Copy link
Contributor Author

Branch renamed, replaced by #962

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant