chore: add retry to tests requiring forwarding #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjaakola-aiven
force-pushed
the
jjaakola-aiven-add-retry-to-tests-requiring-forwarding
branch
4 times, most recently
from
4b6872c to
2ae1e2e
Compare
Coverage report
This PR does not seem to contain any modification to coverable code. |
nosahama
force-pushed
the
jjaakola-aiven-add-retry-to-tests-requiring-forwarding
branch
from
9f811ef to
bc283b3
Compare
jjaakola-aiven
force-pushed
the
jjaakola-aiven-add-retry-to-tests-requiring-forwarding
branch
from
bc283b3 to
e8792b2
Compare
keejon
reviewed
Sep 18, 2024
nosahama
reviewed
Sep 18, 2024
jjaakola-aiven
force-pushed
the
jjaakola-aiven-add-retry-to-tests-requiring-forwarding
branch
from
e8792b2 to
7b43c41
Compare
nosahama
previously approved these changes
Sep 18, 2024
keejon
reviewed
Sep 18, 2024
jjaakola-aiven
force-pushed
the
jjaakola-aiven-add-retry-to-tests-requiring-forwarding
branch
2 times, most recently
from
99712fa to
2fe7d3d
Compare
jjaakola-aiven
force-pushed
the
jjaakola-aiven-add-retry-to-tests-requiring-forwarding
branch
4 times, most recently
from
773afa8 to
0d2c3ac
Compare
nosahama
force-pushed
the
jjaakola-aiven-add-retry-to-tests-requiring-forwarding
branch
from
0d2c3ac to
b0916cf
Compare
nosahama
reviewed
Sep 19, 2024
| # Test primary/replica forwarding with global config setting | ||
| primary_url, replica_url = registry_async_auth_pair | ||
| max_tries, counter = 5, 0 | ||
| wait_time = 0.5 | ||
| for compat in ["FULL", "BACKWARD", "FORWARD", "NONE"]: | ||
| resp = requests.put(f"{replica_url}/config", json={"compatibility": compat}, auth=auth) | ||
| resp = await registry_async_retry_client_auth.put(f"{replica_url}/config", json={"compatibility": compat}, auth=admin) |
There was a problem hiding this comment.
This was failing and we had to split the used auth, aiohttp requires the BasicAuth and requests requires something different, but we were first passing the requests auth to the aiohttp client and it was failing.
nosahama
force-pushed
the
jjaakola-aiven-add-retry-to-tests-requiring-forwarding
branch
from
b0916cf to
09f06a1
Compare
jjaakola-aiven
force-pushed
the
jjaakola-aiven-add-retry-to-tests-requiring-forwarding
branch
from
09f06a1 to
9051154
Compare
jjaakola-aiven
force-pushed
the
jjaakola-aiven-add-retry-to-tests-requiring-forwarding
branch
from
9051154 to
86c3817
Compare
keejon
deleted the
jjaakola-aiven-add-retry-to-tests-requiring-forwarding
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
References: #xxxxx
Why this way