Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error message formatting variable expansion #851

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

tvainika
Copy link
Contributor

About this change - What it does

Fix formatting of error message variable expansion if subject level compatibility mode is not configured.

Why this way

Old code was literally asserting that error message was Subject '%s' does not have subject-level compatibility configured

Fix formatting of error message variable expansion if subject level
compatibility mode is not configured.
@tvainika tvainika requested review from a team as code owners April 17, 2024 10:48
Copy link
Contributor

@aiven-anton aiven-anton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, updated tests will behave more predictably 👍

@aiven-anton aiven-anton merged commit 1331806 into main Apr 17, 2024
8 checks passed
@aiven-anton aiven-anton deleted the fix-subject-level-compat-error-msg-formatting branch April 17, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants