Replace sync Kafka consumers with confluent_kafka one #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matyaskuti
force-pushed
the
matyaskuti/confluent_kafka_sync_consumer
branch
18 times, most recently
from
90714d8 to
26ea01d
Compare
matyaskuti
changed the title
matyaskuti
force-pushed
the
matyaskuti/confluent_kafka_sync_consumer
branch
4 times, most recently
from
78ce72e to
4740bab
Compare
matyaskuti
commented
Dec 4, 2023
matyaskuti
force-pushed
the
matyaskuti/confluent_kafka_sync_consumer
branch
3 times, most recently
from
981fa69 to
0039127
Compare
matyaskuti
commented
Dec 12, 2023
eliax1996
reviewed
Dec 12, 2023
eliax1996
reviewed
Dec 12, 2023
eliax1996
reviewed
Dec 12, 2023
eliax1996
reviewed
Dec 12, 2023
There was a problem hiding this comment.
Almost convinced its fine, just want to discuss a little bit on the doubt I've asked 😁, when @aiven-anton take a look I'm fine with merging
matyaskuti
force-pushed
the
matyaskuti/confluent_kafka_sync_consumer
branch
2 times, most recently
from
ea02eb7 to
7a31284
Compare
aiven-anton
reviewed
Dec 12, 2023
matyaskuti
force-pushed
the
matyaskuti/confluent_kafka_sync_consumer
branch
from
7a31284 to
d3e000f
Compare
aiven-anton
reviewed
Dec 12, 2023
matyaskuti
force-pushed
the
matyaskuti/confluent_kafka_sync_consumer
branch
from
d3e000f to
770ff3d
Compare
1 task
matyaskuti
force-pushed
the
matyaskuti/confluent_kafka_sync_consumer
branch
6 times, most recently
from
640a9d0 to
fda504b
Compare
aiven-anton
reviewed
Dec 13, 2023
matyaskuti
force-pushed
the
matyaskuti/confluent_kafka_sync_consumer
branch
2 times, most recently
from
8e0f0d4 to
e91aafa
Compare
aiven-anton
reviewed
Dec 13, 2023
| start_offset: int = consumer.beginning_offsets([topic_partition])[topic_partition] | ||
| end_offset: int = consumer.end_offsets([topic_partition])[topic_partition] | ||
| ) -> Iterator[Message]: | ||
| start_offset, end_offset = consumer.get_watermark_offsets(topic_partition) |
There was a problem hiding this comment.
I had another doubt this was correct due to mix of terminology, but have now verified it's the same underlying Protocol message involved (ListOffsets):
- https://github.com/confluentinc/librdkafka/blob/df6efd25e6e44c06a937cbdf8fc81715668e0ce1/src/rdkafka.c#L3597
- https://github.com/dpkp/kafka-python/blob/0864817de97549ad71e7bc2432c53108c5806cf1/kafka/consumer/fetcher.py#L573
So looks correct 👍
This change replaces all synchronous Kafka consumers (from the kafka-python library) with a new implementation based on confluent-kafka-python's `Consumer`, keeping the same interface as much as possible. The PyTest timeout is raised from 60s to 90s to accomodate for the default poll timeout for backups consumers (otherwise the tests would time out while still waiting for messages to arrive).o Since the `conluent_kafka.Consumer` implementation does not allow for consumers to be without a group ID, if the new `KafkaConsumer` client is not given one, we'll generate one on the fly to mimic a groupless behaviour. Resources: * confluent-kafka-python documentation: https://docs.confluent.io/platform/current/clients/confluent-kafka-python/html/index.html# * librdkafka configuration documentation: https://github.com/confluentinc/librdkafka/blob/master/CONFIGURATION.md
matyaskuti
force-pushed
the
matyaskuti/confluent_kafka_sync_consumer
branch
from
e91aafa to
dd0ec0f
Compare
eliax1996
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
karapace.kafka.typesmodule introduced to consolidate additional data types used from confluent-kafka (to a certain extent, see comment thread)Why this way
KarapaceKafkaClientstill remain)Keeping confluent-kafka references inthis was agreed to be simplified and not be a goal after allkarapace.kafka.*