Fix subject name strategy config and add validation flag #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow setting `name_strategy` from config, and fix documentation to match default that has been in the implementation so far.
Before Karapace 3.7.0 when producing messages with REST API Karapace did not validate that given schema belongs to valid subject as per name strategy. Add a setting to disable this validation to allow easily skip name strategy validation optionally.
tvainika
force-pushed
the
subject-name-strategy
branch
from
4ef570c to
a46d3e1
Compare
|
Did I understood it correctly that this is globally and not for each topic? Doesn’t make sense to enable/disable it by topic? Same question for the strategy |
|
Yes, this is global config that allows easy backward mode that is compatible with pre 3.7.0 karapace |
|
for disabling the schema I can agree that having something global can make sense but for the type of strategy we need to enable the customisation on a topic level. Also I would argue that someone could want to enable the validation in a topic based way since you can have flows that aren’t validated and flow that are |
giuseppelillo
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
Fix subject
name_strategyconfiguration setting, which we have had kind of documented but not working. Now it is possible to set it, and use it. Also fixes documentation to match what has been the default in the implementation.Add new configuration option
name_strategy_validation(true by default) which allows skipping subject name strategy validation when producing messages with Kafka REST calls.References: #664 and #724
Why this way
This enables easy backward compatible behaviour of producing with REST using any schema.