Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema_registry: breaking change in an error message #228

Merged
merged 1 commit into from
May 26, 2021
Merged

schema_registry: breaking change in an error message #228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion karapace/schema_registry_apis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -697,7 +697,7 @@ async def subjects_schema_post(self, content_type, *, subject, request):
self.r(
body={
"error_code": SchemaErrorCodes.HTTP_INTERNAL_SERVER_ERROR.value,
"message": "Internal Server Error",
"message": f"Error while looking up schema under subject {subject}",
},
content_type=content_type,
status=HTTPStatus.INTERNAL_SERVER_ERROR,
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/test_schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1270,7 +1270,7 @@ async def test_schema_subject_post_invalid(registry_async_client: Client) -> Non
res = await registry_async_client.post(f"subjects/{subject_1}", json={})
assert res.status == 500
assert res.json()["error_code"] == 500
assert res.json()["message"] == "Internal Server Error"
assert res.json()["message"] == f"Error while looking up schema under subject {subject_1}"

# Schema not included in the request body for subject that does not exist
subject_3 = subject_name_factory()
Expand Down