Sync kafka settings #179
Sync kafka settings #179
Conversation
hackaugusto
commented
Mar 23, 2021
hackaugusto
commented
- update kafka/zookeeper container versions
- change from cp-server to cp-kafka which is the community edition
- made sure the docker-compose and the pytest fixtures use the same settings
| KAFKA_CURRENT_VERSION = "2.4" | ||
| BASEDIR = "kafka_2.12-2.4.1" | ||
| BASEDIR = "kafka_2.13-2.7.0" |
There was a problem hiding this comment.
The line above has KAFKA_CURRENT_VERSION = "2.4", but this PR switches to Kafka 2.7. I see that KAFKA_CURRENT_VERSION is used only for protocol version related settings, but reflecting to comment line before is confusing. What software versions and protocol versions should be defined and where?
There was a problem hiding this comment.
I'm not sure why KAFKA_CURRENT_VERSION is necessary, I just synchronized the files. Unfortunately setting it to 2.7.0 crashes Kafka
There was a problem hiding this comment.
I'm fine with updating the comments here (and possibly in Makefile) about what versions need to be in sync. Also what about renaming KAFKA_CURRENT_VERSION to something like KAFKA_PROTOCOL_VERSION?
There was a problem hiding this comment.
I must have used an outdated version of the container image. I did check the documentation and tried it again, and the protocol version set as the current version works. Edit: I updated the value
hackaugusto
force-pushed
the
hacka-sync-compose-and-conf-test
branch
from
aa1087f to
cbcbd63
Compare
