Update kafka-python and fix api change. #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe add note about kafka-python to commit message also. Otherwise, LGTM. |
I don't follow, the link to the upstream PR? |
Just the commit in this pull, that it updates the requirements-dev.txt |
after code review upstream, the argument name changed from client_factory to kafka_client. Updated the `kafka-python` dependency to use new master from `aiven` fork. The `master` is up-to-date with upstream, it also has sock5 support and a bugfix.
hackaugusto
force-pushed
the
hacka/update-kafka-python-dependency
branch
from
af7749b to
a3ca703
Compare
|
@mts-aiven updated the commit message |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git+git://github.com/aiven/kafka-python.git@346c01e4eec6bdcccc99ca613b79020f3be35eb7is the current commit for https://github.com/aiven/kafka-python/tree/aiven_patches , which is rebased on top of dpkp's master.masterwas updated instead, it is the same commit but now master points to it.During the review fo dpkp/kafka-python#2144 the configuration key changed name.