Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: OTel metrics & metering #1011

Open
wants to merge 2 commits into
base: jjaakola-aiven-fastapi
Choose a base branch
from

Conversation

nosahama
Copy link
Contributor

@nosahama nosahama commented Dec 19, 2024

About this change - What it does

  • we add OTel metering and HTTP metrics to the service.
  • the metrics are exported to prometheus via the opentelemetry-collector as shown below
Screenshot 2024-12-19 at 10 47 58
  • no changes to the grafana dashboard shows that the prometheus source still works as expected
Screenshot 2024-12-19 at 10 49 00

Follow up

  • update the schema_reader metrics to use the OTel meter
  • maybe deprecate statsd
  • close the prometheus PR instrumentation: fastapi prometheus middleware #1007 as we now use the OTel metering and exporting to prometheus, thus native prometheus instrumentation is not needed

@nosahama nosahama requested review from a team as code owners December 19, 2024 09:51
@nosahama nosahama force-pushed the nosahama/EC-681/otel-metrics branch 3 times, most recently from e06b32e to 7c9d0c6 Compare December 19, 2024 11:27
Copy link

github-actions bot commented Dec 19, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  src/karapace
  config.py
  src/schema_registry
  __main__.py 20
  factory.py 20, 62
  src/schema_registry/telemetry
  container.py
  meter.py
  middleware.py
  setup.py 35-36
Project Total  

This report was generated by python-coverage-comment-action

@nosahama nosahama force-pushed the nosahama/EC-681/otel-metrics branch from 7c9d0c6 to 1b21afc Compare December 20, 2024 11:34
@nosahama nosahama force-pushed the nosahama/EC-681/otel-metrics branch from 1b21afc to 944a4f1 Compare December 20, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant