-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: open telemetry traces setup #1009
Merged
jjaakola-aiven
merged 9 commits into
jjaakola-aiven-fastapi
from
nosahama/EC-674/otel-traces-basic-setup
Dec 20, 2024
Merged
feat: open telemetry traces setup #1009
jjaakola-aiven
merged 9 commits into
jjaakola-aiven-fastapi
from
nosahama/EC-674/otel-traces-basic-setup
Dec 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nosahama
force-pushed
the
nosahama/EC-674/otel-traces-basic-setup
branch
2 times, most recently
from
December 16, 2024 16:37
57b07bc
to
abe7bc7
Compare
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
nosahama
force-pushed
the
nosahama/EC-674/otel-traces-basic-setup
branch
2 times, most recently
from
December 17, 2024 09:16
e990750
to
f2c52ed
Compare
87131a0 shows how to add tracing to |
nosahama
force-pushed
the
nosahama/EC-674/otel-traces-basic-setup
branch
7 times, most recently
from
December 19, 2024 11:23
48fd46f
to
f10aa3d
Compare
- we move the schema reader and registry - we rename the apis to controller and updates to the DI wiring
- we also build a custom resource
- this still relies on DI wiring, but avoids changing function signatures - API routes are injected and wired as normal
nosahama
force-pushed
the
nosahama/EC-674/otel-traces-basic-setup
branch
from
December 19, 2024 12:00
f10aa3d
to
b0e4b63
Compare
jjaakola-aiven
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
We add open telemetry traces to schema-registry.
schema_registry
module, this also affects the PR coverage:src/karapace/schema_registry.py
→src/schema_registry/registry.py
src/karapace/schema_reader.py
→src/schema_registry/reader.py
src/schema_registry/schema_registry_apis.py
→src/schema_registry/controller.py
_health
endpoint is traced, we can build up from hereExample traces from the
/_health
endpointAPI span data
Healthcheck endpoint handler span data
Note: the entries under
Logs
are not logs from the pythonlogging
module or any other configured logger, but these are OTel span events, OTel logs and metrics will be added in future iterations.Now with
KafkaSchemaReader.ready()
traced, we can clearly see from the UI thatMasterCoordinator.get_coordinator_status()
callsKafkaSchemaReader.ready()
which was also called somewhere at the beginning of the endpoint handler.