Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Pipeline] Tests run twice on Pull Request Creation #271

Closed
jlprat opened this issue Aug 2, 2021 · 1 comment
Closed

[Pipeline] Tests run twice on Pull Request Creation #271

jlprat opened this issue Aug 2, 2021 · 1 comment
Labels
bug Something isn't working test Test related issue

Comments

@jlprat
Copy link
Contributor

jlprat commented Aug 2, 2021

What happened?

When a new pull request is created the test suite is run twice:

  • One because it's triggered at pull request creation
  • One because there is a push event

What did you expect to happen?

The test suite is run only once when the following happens:

  • Pull request creation (pr creation + push)
  • Pushing more than one commit at a time
  • Re opening the pull request
@jlprat jlprat added bug Something isn't working test Test related issue labels Aug 2, 2021
@jlprat
Copy link
Contributor Author

jlprat commented Aug 2, 2021

Actually, Linting also suffers from the same thing

jlprat added a commit that referenced this issue Aug 3, 2021
@jlprat
Config GitHub actions to avoid double triggering #271
26478c0 
References: #271
Lint and tests will now run when:
- A PR is created, updated, reopened...
- A push event happens on the master branch
@jlprat jlprat mentioned this issue Aug 3, 2021
Merged
hackaugusto pushed a commit that referenced this issue Aug 4, 2021
Merge pull request #272 from aiven/run-lint-and-tests-once-per-pr
f85a697 
Config GitHub actions to avoid double triggering #271

#272
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working test Test related issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hackaugusto @jlprat