Use pre-commit for linting

This change introduces pre-commit for managing linting config
and tool versions.

.github/workflows/lint.yml

@@ -6,22 +6,18 @@ jobs:
   lint:
     runs-on: ubuntu-latest
     steps:
-      - name: Setup python
+      - uses: actions/checkout@v2
+
+      - name: Set up Python 3.7
         uses: actions/setup-python@v1
         with:
           python-version: 3.7
-          architecture: x64
-
-      - uses: actions/checkout@master
 
       - name: Install dependencies
         run: pip install -r requirements-dev.txt
 
-      - name: Run flake8
-        run: make flake8
-
-      - name: Run pylint
-        run: make pylint
+      - name: Run all pre-commit hooks
+        run: make lint
 
   copyright:
       runs-on: ubuntu-latest

.pre-commit-config.yaml

@@ -0,0 +1,50 @@
+repos:
+  - repo: https://gitlab.com/pycqa/flake8
+    rev: 3.7.9
+    hooks:
+      - id: flake8
+        files: \.py$
+        args:
+          - --config=.flake8
+
+  - repo: https://github.com/pre-commit/mirrors-yapf
+    rev: v0.27.0
+    hooks:
+      - id: yapf
+        files: \.py$
+        exclude: ^vendor/
+        args:
+          - --parallel
+          - --recursive
+          - --in-place
+
+  - repo: https://github.com/timothycrosley/isort
+    rev: 4.3.21
+    hooks:
+      - id: isort
+        files: \.py$
+        exclude: ^vendor/
+        args:
+          - --recursive
+
+  - repo: https://github.com/pre-commit/pre-commit-hooks
+    rev: v2.5.0
+    hooks:
+      - id: trailing-whitespace
+        exclude: ^vendor/|^tests/.*/fixtures/.*
+      - id: end-of-file-fixer
+        exclude: ^vendor/|^tests/.*/fixtures/.*
+      - id: debug-statements
+
+  # https://pre-commit.com/#repository-local-hooks
+  - repo: local
+    hooks:
+      - id: pylint
+        name: pylint
+        entry: pylint
+        language: system
+        types: [python]
+        files: \.py$
+        exclude: ^vendor/
+        args:
+          - --rcfile=.pylintrc

Makefile

@@ -65,11 +65,11 @@ kafka: start-kafka
 
 .PHONY: pylint
 pylint: $(GENERATED)
-	python3 -m pylint --rcfile .pylintrc $(ALL_PYTHON_DIRS)
+	pre-commit run pylint --all-files
 
 .PHONY: flake8
 flake8: $(GENERATED)
-	python3 -m flake8 --config .flake8 $(ALL_PYTHON_DIRS)
+	pre-commit run flake8 --all-files
 
 .PHONY: copyright
 copyright:
@@ -80,20 +80,25 @@ unittest: fetch-kafka $(GENERATED)
 	python3 -m pytest -s -vvv tests/
 
 .PHONY: test
-test: flake8 pylint reformat copyright unittest
+test: lint copyright unittest
 
 .PHONY: isort
 isort:
-	time isort --recursive $(ALL_PYTHON_DIRS)
+	pre-commit run isort --all-files
 
 .PHONY: yapf
 yapf:
-	time yapf --parallel --recursive --in-place $(ALL_PYTHON_DIRS)
+	pre-commit run yapf --all-files
 
 .PHONY: reformat
 reformat: isort yapf
-	[ $(shell git diff --name-only | wc -l) -eq 0 ] || (echo "please reformat code and re-commit" && exit 1)
 
+.PHONY: pre-commit
+pre-commit: $(GENERATED)
+	pre-commit run --all-files
+
+.PHONY: lint
+lint: pre-commit
 
 /usr/lib/rpm/check-buildroot /usr/bin/rpmbuild:
 	$(DNF_INSTALL) rpm-build

requirements-dev.txt

@@ -1,8 +1,7 @@
 avro-python3==1.9.2.1
 kafka-python==2.0.1
 aiohttp-socks==0.3.4
-flake8==3.7.9
 pylint==2.4.4
 pytest==5.4.1
 requests==2.23.0
-yapf==0.27.0
+pre-commit>=2.2.0