Merge pull request #304 from aiven/hacka-remove-dead-code

cleanup: removed dead code
Aiven-Open · Jan 28, 2022 · 3b4117b · 3b4117b
2 parents 6111c6d + e71317e
commit 3b4117b
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 7 deletions.
diff --git a/karapace/protobuf/schema.py b/karapace/protobuf/schema.py
@@ -135,7 +135,6 @@ def to_schema(self) -> str:
         if shm.options:
             strings.append("\n")
             for option in shm.options:
-                # strings.append(str(option.to_schema_declaration()))
                 strings.append(option_element_string(option))
 
         if shm.types:

diff --git a/karapace/protobuf/utils.py b/karapace/protobuf/utils.py
@@ -64,4 +64,3 @@ def append_indented(data: List[str], value: str) -> None:
 
 RESERVED_TAG_VALUE_START = 19000
 RESERVED_TAG_VALUE_END = 19999
-""" True if the supplied value is in the valid tag range and not reserved.  """
diff --git a/tests/unit/test_proto_parser.py b/tests/unit/test_proto_parser.py
@@ -452,11 +452,6 @@ def test_invalid_trailing_comment():
         |}
         """
     proto = trim_margin(proto)
-    # try :
-    #   ProtoParser.parse(location, proto)
-    # except IllegalStateException as e :
-    #    if e.message != "Syntax error in file.proto:2:12: expected '//' or '/*'" :
-    #        pytest.fail("")
 
     with pytest.raises(IllegalStateException) as re:
         # TODO: this test in Kotlin source contains "2:13:" Need compile square.wire and check how it can be?
Original file line number	Diff line number	Diff line change
Expand Up		@@ -64,4 +64,3 @@ def append_indented(data: List[str], value: str) -> None:

		RESERVED_TAG_VALUE_START = 19000
		RESERVED_TAG_VALUE_END = 19999
		""" True if the supplied value is in the valid tag range and not reserved. """