Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabling integration tests in CI #224

Merged
merged 2 commits into from
Mar 13, 2023
Merged

Enabling integration tests in CI #224

merged 2 commits into from
Mar 13, 2023

Conversation

AnatolyPopov
Copy link
Contributor

@AnatolyPopov AnatolyPopov commented Mar 10, 2023 •
edited by C0urante
Loading

Addresses #221

@AnatolyPopov AnatolyPopov requested review from a team as code owners March 10, 2023 09:45
C0urante
C0urante approved these changes Mar 10, 2023
View reviewed changes
Copy link
Contributor

@C0urante C0urante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thought this would be a lot harder! Didn't realize Testcontainers would play this nicely with GH actions. Thanks @AnatolyPopov!

@C0urante C0urante mentioned this pull request Mar 10, 2023
Merged
jeqo
jeqo approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@jeqo jeqo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @AnatolyPopov

@jeqo jeqo merged commit 5ee4d69 into master Mar 13, 2023
@jeqo jeqo deleted the enable-integration-tests-in-ci branch March 13, 2023 08:16
This was referenced Mar 27, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@C0urante C0urante C0urante approved these changes

@jeqo jeqo jeqo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AnatolyPopov @jeqo @C0urante